Activity
There was a problem fetching the latest activity.
This Week
dmitshur commented on golang.org/x/build: test failures are hard to discover2d
Issue #74323 might be relevant here.
It appears that the reason the package `golang.org/x/tools/gopls/internal/test/marker` tests are reported as failed is because of the data race that came up duri…dmitshur commented on : go1.23.11 segmentation fault in test2d
CC @golang/runtime.dmitshur reopened an issue cmd/compile/internal/ssa: TestStmtLines fails due to auto-generated crypto code4d
Reopening to track removal of the [test skip](https://cs.opensource.google/go/go/+/master:src/cmd/compile/internal/ssa/stmtlines_test.go;l=106-108;drc=4a3cef2036097d323b6cc0bbe90fc4d8c7588660). (CC @…Last Week
dmitshur closed an issue sum.golang.org: Update hash of github.com/xmppo/go-xmpp1w
In the general case, the moment a tag is published, it's not viable to modify its contents without potentially causing problems. Instead, it's possible for you to publish a newer version that correct…Earlier
dmitshur commented on runtime: TestNeedmDeadlock failures2w
The only potentially relevant recent builder change I can think of is [crrev.com/c/6641842](https://crrev.com/c/6641842) (CC @mknyszek) which rebalanced test sharding strategy for #65814. Its timing …dmitshur commented on runtime: TestNeedmDeadlock failures2w
This test has started to fail very often on the gotip-linux-arm64-asan-clang15 linux specifically recently. As visible in its [history](https://ci.chromium.org/ui/test/golang/runtime.TestNeedmDeadloc…dmitshur fixed an issue access: approvers2w
Hi Julian,
Thank you for contributing to the Go project, and for your work of being a maintainer of the MIPS ports. We've discussed this request on the team and agreed to grant you this access. I've…dmitshur commented on : Clang 18+ does not support the '-arch' switch (Android NDK binaries)2w
CC @golang/android.dmitshur commented on cmd/link: duplicated definition of symbol github.com/ebitengine/purego.syscall15XABI0 when running with ASAN [1.24 backport]2w
We discussed this and agreed to proceed with the backport. Thanks.dmitshur commented on cmd/compile: devirtualized type switch causes temporary allocation to escape2w
CC @golang/compiler.dmitshur commented on reflect: TypeAssert[T] is not identical to Interface().(T)2w
CC @golang/runtime.dmitshur commented on slices: TestIssue68488 seems sensitive to minor stack perturbations2w
CC @Jorropo, @randall77.dmitshur commented on cmd/go: go tool does not accept -mod=2w
CC @golang/command-line.dmitshur commented on cmd/go: open C:\Windows\TEMP: Access is denied.2w
If more time is desired and the trade-offs are appropriate, also consider the path of reverting the change that caused this regression, reopening #52745, and trying again in a future cycle.dmitshur pushed to
main in rsc.io/rf2w
dmitshur merged a change rsc.io/rf/...: fix detection of unused variable2w
dmitshur reviewed +2 on rsc.io/rf/...: fix detection of unused variable2w
The check fails for reasons unrelated to the change here. The module requires Go 1.20 but the check tries to test with Go 1.16 (which is before [go.dev/doc/toolchain](https://go.dev/doc/toolchain#sel…dmitshur pushed to
main in rsc.io/rf2wdmitshur merged a change rsc.io/rf/...: use os.WriteFile instead of ioutil.WriteFile2w
dmitshur reviewed +2 on rsc.io/rf/...: use os.WriteFile instead of ioutil.WriteFile2w
LGTM. Thanks.dmitshur commented on cmd/compile/internal/escape: optimization wrongly affecting panics2w
CC @golang/compiler.dmitshur commented on reflect: Value.Seq|Seq2 documentation and unexported value2w
CC @golang/runtime.dmitshur commented on cmd/cover: wrong coverage reported when func fields in struct2w
CC @thanm, @golang/compiler.dmitshur commented on net/http: punycode labels ending with hyphen (xn--example-) should be rejected per updated UTS-462w
Thanks for filing the issue. Someone familiar with this package may have more specific comments, but in general please see https://go.dev/doc/contribute on how to send a code change. I added a mentio…dmitshur commented on golang.org/x/sys/windows: fix filetime conversions and deprecate Nanoseconds2w
CC @golang/windows.dmitshur commented on internal/goexperiment: user facing documentation for GOEXPERIMENT points to internal source for list of supported values2w
CC @golang/command-line, @golang/runtime.dmitshur commented on wasm: passing a JS pointer to Go-Wasm runtime causes memory leak2w
CC @golang/wasm.dmitshur commented on cmd/go: clean doesn't respect workspace vendoring2w
CC @golang/command-line.dmitshur commented on cmd/go/internal/test: "go help testflag" refers to legacy options of pprof2w
CC @golang/command-line, @cherrymui.dmitshur opened an issue cmd/go: "test timed out after ... running tests: ..." attached to one of many subtests in JSON mode, can be less visible compared to non-JSON output3w
Consider the output from `go test` without `-json` flag in a situation where a test timeout happens while multiple subtests are still running (as happened in #74279):
```sh
$ go version
go version g…dmitshur starred github.com/jamesshenjian/jpegsl3w
dmitshur commented on github.com/shurcooL/home/internal/exp/service/activity/{github,gerrit}: walkSegMail can fail with EOF3w
There was another instance, but this time it was with a non-zero offset in the middle of a month:
```
2025/06/18 14:21:34 service/activity/github: mailLoop: walkSegMail(github.fileSeg{file:"/2025-06…dmitshur fixed an issue golang.org/x/build: have darwin/arm64 builders on macOS 13 (Ventura)3w
dmitshur commented on golang.org/x/build: have darwin/arm64 builders on macOS 13 (Ventura)3w
This was done a while back ([CL 532579](https://go.dev/cl/532579)).dmitshur opened an issue golang.org/x/build/internal/installer/darwinpkg: unclear purpose and effect of "Fixing permissions" step during postinstall3w
The Go macOS installer currently runs a sequence of commands described as "Fixing permissions":
```bash
GOROOT=/usr/local/go
echo "Fixing permissions"
cd $GOROOT
find . -exec chmod ugo+r \{\} \;
fin…dmitshur commented on golang.org/x/build: gotip-linux-arm builder has no disk space left4w
I terminated the bot via swarming UI:
<img width="892" alt="Image" src="https://github.com/user-attachments/assets/21ce9cd4-5236-479d-aedd-fd341aeba18a" />
After it came back, it had a successful …dmitshur fixed an issue golang.org/x/build: gotip-linux-arm builder has no disk space left4w
dmitshur fixed an issue golang.org/x/tools: frequent out-of-memory errors on linux-arm builder4w
dmitshur commented on golang.org/x/tools: frequent out-of-memory errors on linux-arm builder4w
The Scaleway linux/arm builders are no more, and there haven't been recent reports here. If this comes up on the newer linux/arm builders, watchflakes will file a report. Closing.dmitshur starred github.com/firstrow/mcwig4w
dmitshur commented on cmd/compile: update compiler's PGO profile as part of rc1 relui flow1mo
> At this point it might help to separate out work on making relui do this automatically into a dedicated x/build/cmd/relui issue, since that can happen independently of the Go release cycle.
Made #…dmitshur opened an issue golang.org/x/build/cmd/relui: update compiler's PGO profile1mo
This is a tracking issue to create a task for updating the compiler's PGO profile, something that we currently typically do for every major Go release, so about once every 6 months (issue #60234).
I…dmitshur fixed an issue all: end support for macOS 11 in Go 1.251mo
dmitshur commented on all: end support for macOS 11 in Go 1.251mo
I think we can close this now - I'm not aware of anything more left to do for this for Go 1.25.
If there's anything still in the tree that exists only because of needing to support macOS 11, then th…dmitshur commented on cmd/dist: re-expose pack command in Go 1.251mo
Thanks for the report. The corresponding release note for this is https://tip.golang.org/doc/go1.25#go-command (second paragraph, "The Go distribution will include fewer prebuilt tool binaries. …")…dmitshur commented on golang.org/x/build/cmd/relui: bypass trybots for VERSION file CLs1mo
Permission change applied.dmitshur fixed an issue golang.org/x/build/cmd/relui: bypass trybots for VERSION file CLs1mo
dmitshur fixed an issue os: TestRootRemoveDot failing on Plan 91mo
dmitshur reopened an issue golang.org/x/build/cmd/relui: bypass trybots for VERSION file CLs1mo
Need to grant the gobot account a permission for the TryBot-Bypass label, since it is being used by it now. Reopening for that.dmitshur opened an issue golang.org/x/build: extend main Go repo's "every vet check is forcibly made high-confidence" behavior to golang.org/x packages that are vendored (or exclude vendored packages from it)1mo
The `go test` command normally runs a select subset of vet checks, and fails the test if any of them fail.
In the main Go repo, to aid development, that behavior is forcibly modified to have all vet…dmitshur commented on golang.org/x/build/cmd/watchflakes: no reports after May 19, 20251mo
[CL 678816](https://go.dev/cl/678816) is working, and watchflakes has started posting again. I'll keep an eye on it in the short term, and issue #70743 still remains open to track unexpected restarts.dmitshur opened an issue golang.org/x/exp/rand: isolate into nested module, tag, delete1mo
This issue tracks a remaining subset of the accepted proposal #61716. Specifically:
> Once math/rand/v2 has shipped, we would tag and delete x/exp/rand. This would keep programs that already use x/e…dmitshur commented on testing: add missing Output method to testing.TB1mo
Indeed—freeze exceptions would be needed for changes that aren't in scope of the freeze (and ideally they need to be filed and approved before the freeze), but finding and resolving issues in new-t…dmitshur commented on access: please add new email to existing account1mo
Great! I've also updated your email in the approvers group now, so everything should continue to work.
Just as a reminder, please be familiar with the rules for voting and submitting changes as desc…dmitshur commented on cmd/internal/moddeps: TestAllDependencies/std(thorough) failures [consistent failure]1mo
Latest instance fixed in [CL 663975](https://go.dev/cl/663975).dmitshur fixed an issue cmd/internal/moddeps: TestAllDependencies/std(thorough) failures [consistent failure]1mo
dmitshur commented on golang.org/x/build: add darwin-arm64 longtest and race builders1mo
The darwin-arm64-longtest builder is passing at tip and on the Go 1.24 release branch, but it has one failing test on the Go 1.23 release branch. I filed #73922 for it.
The darwin-arm64-race builder…dmitshur opened an issue cmd/go: TestScript/build_trimpath_cgo fails to decode dwarf on release-branch.go1.231mo
### Go version
This affects Go 1.23.x only. The test passes on Go 1.24.x and at tip.
### Output of `go env` in your module/workspace:
```shell
GOOS='darwin'
GOARCH='arm64'
```
### What did you do…dmitshur commented on golang.org/x/build/cmd/watchflakes: no reports after May 19, 20251mo
The problem appears to be due to a regression in the result_adapter command in [crrev.com/c/6554882](https://crrev.com/c/6554882) from May 19, 2025, which has a pending fix in [crrev.com/c/6598395](h…dmitshur opened an issue golang.org/x/build/cmd/watchflakes: no reports after May 19, 20251mo
The most recent new issue watchflakes opened was #73775 on May 19, 2025. It appears to have gotten almost entirely stuck as of that date, and isn't producing reports. This is the tracking issue.
The…dmitshur commented on access: please add new email to existing account1mo
@ysmolski Glad to hear that you were able to update the email in your Gerrit account! It indeed shows up as expected at https://go-review.googlesource.com/dashboard/26536.
About the CLA page, in the…dmitshur commented on access: approvers1mo
CC @4a6f656c, @Rongronggg9, @milanknezevic, @mengzhuo Since you're also members of [golang/mips](https://github.com/orgs/golang/teams/mips) and [golang/riscv64](https://github.com/orgs/golang/teams/r…dmitshur fixed an issue github.com/shurcooL/graphql: Please make "constructQuery" exported1mo
dmitshur commented on github.com/shurcooL/graphql: Please make "constructQuery" exported1mo
The current implementation of `constructQuery` is very tailored to the needs of the rest of the graphql package. It doesn't take any options, like the ability to include spaces in formatting, and doe…dmitshur commented on text/template: index/element switched for iter.Seq2 in range1mo
Since it's not already mentioned here, the proposal for this was #66107, and the accepted plan there was:
> The proposal is to allow range over func and int the same as in Go.
The current implement…dmitshur commented on golang.org/x/tour/tour: Missing a period at the end of the last sentence.1mo
For clarity, it looks like "Methods and interfaces" was referring to the section title:
dmitshur commented on golang.org/x/build/internal/releasetargets: update for each upcoming major Go release1mo
[CL 664215](https://go.dev/cl/664215) generated a preliminary list for Go 1.25. It's the same list as for Go 1.24 except the macOS minimum version became 12, and that's noted at https://tip.golang.or…dmitshur commented on all: announce end of support for old Linux versions1mo
There isn't anything to pre-announce in Go 1.25 release notes, moving to the next.dmitshur commented on all: announce end of support for old Windows releases1mo
There isn't anything to pre-announce in Go 1.25 release notes, moving to the next.dmitshur commented on github.com/go-gl/gl: Problem with getting v2.1 gl1mo
The package requires cgo, so it’s possible to get that error if you’ve disabled cgo. Does anything change if you use CGO_ENABLED=1?dmitshur commented on access: please add new email to existing account1mo
Hello.
If you're still able to login to your Gerrit account 26536, you should be able to add and verify a new email (and then make it your new primary preferred email, if desired). The reason you're…dmitshur commented on cmd/go: build and run tools that are not necessary for builds as needed and don't include in binary distribution1mo
Does this need a release note (#71661)?dmitshur fixed an issue github.com/shurcooL/vfsgen: Possible to pack SQLite file?1mo
dmitshur commented on golang.org/x/build: bot linux-riscv64-mengzhuo--megrez-1 reported as broken1mo
Thanks for addressing this so quickly. I've closed this since the builder is back online and working. If it's useful to have an open issue, we can make a new one.dmitshur fixed an issue golang.org/x/build: bot linux-riscv64-mengzhuo--megrez-1 reported as broken1mo
dmitshur closed a change golang.org/x/build: Rename README.md to -github.com-binance-exchange-binance-official-/ap…1mo
dmitshur commented on os: new test TestOpenFileCreateExclDanglingSymlink fails on Plan 91mo
CC @golang/plan9, @neild.dmitshur closed an issue github.com/gopherjs/gopherjs: Arrays internalized as maps1mo
Perhaps the "not planned" reason is more applicable here, since there was no change.dmitshur commented on golang.org/x/crypto/x509roots/fallback: high, unskippable, init cost1mo
CC @rolandshoemaker, @FiloSottile.dmitshur opened an issue golang.org/x/arch/riscv64/riscv64asm: TestObjdumpRISCV64TestDecodeGNUSyntaxdata stalls on linux/s390x2mo
See https://ci.chromium.org/b/8715046913413654785 for example:
```
=== RUN TestObjdumpRISCV64TestDecodeGNUSyntaxdata
panic: test timed out after 10m0s
running tests:
TestObjdumpRISCV64TestDecod…dmitshur opened an issue golang.org/x/crypto/sha3: TestMarshalUnmarshal/SHA3-224 fails on linux/s390x2mo
See https://ci.chromium.org/b/8715046724760256497 for example:
```
=== RUN TestMarshalUnmarshal
--- FAIL: TestMarshalUnmarshal (0.00s)
panic: interface conversion: *sha3.asmState is not encoding.B…dmitshur commented on golang.org/x/build: add LUCI linux-s390x builder2mo
Great, thank you.
I think all that's left on our side is to adjust the builder configuration to let the builder run on applicable golang.org/x repositories (it was set to try only the main Go repo w…dmitshur commented on golang.org/x/build: add LUCI linux-s390x builder2mo
Glad to hear that, and congrats on getting to this point!
The swarming bot generally takes care of using all of the CPU cores and machine capacity available to it, so the typical setup is to have on…dmitshur closed an issue go/version: IsValid reports false on inputs like "go1.8.5rc5", "go1.9.2rc2"2mo
I've had a chance to talk with Russ about this, and he confirmed that these "go1.8.5rc5" and "go1.9.2rc2" versions aren't really proper Go releases—they're side-effects that happened to be produced…dmitshur commented on go/version: doesn't handle devel toolchain versions2mo
We've taken the alternative route of making the generated development versions be compatible with the existing https://go.dev/doc/toolchain#name format (as a "non-standard toolchain") in #73372. Is t…dmitshur commented on github.com/andygrunwald/go-gerrit/fix: handle changes/<change>/patch JSON marshalling error2mo
I left some review comments from a quick look, I hope they're helpful. I haven't tried to test the changes locally so I may have missed something.
In general, the test seems to be useful, but I th…dmitshur commented on github.com/go-delve/delve/goversion: fix development version parsing2mo
Thank you!dmitshur fixed an issue runtime: timeouts on netbsd-arm64-bsiegert builder2mo
dmitshur commented on runtime: timeouts on netbsd-arm64-bsiegert builder2mo
This issue has stopped matching because this builder in LUCI no longer has -bsiegert in the name (it's still there in the underlying bot name, but the pattern uses builder name), but there've been so…dmitshur closed an issue golang.org/x/build: netbsd-amd64-8_0 builder timing out frequently2mo
The netbsd-amd64-8_0 builder doesn't exist by now, closing.dmitshur opened an issue golang.org/x/build: timeout on netbsd-arm64 builder2mo
```
#!watchflakes
default <- builder ~ `netbsd-arm64` && "panic: test timed out after 10m0s"
```
Filing this to hopefully catch future instances of issues like #73487, where the underlying problem w…dmitshur fixed an issue golang.org/x/build: LUCI support for plan92mo
dmitshur commented on golang.org/x/build: LUCI support for plan92mo
I believe by now we have resolved the general approach to support Plan 9 testing on LUCI. The plan9 arm and 386 builders seem to be generally working okay for a while now. The amd64 builder seems to …dmitshur commented on golang.org/x/build: bot mac-330-h526 reported as broken2mo
I'm not sure why this issue was opened 9 hours ago. Given #72857 is now resolved, this should happen only if the builder is dead for 24 hrs, but from looking at [its task history](https://chromium-sw…dmitshur commented on golang.org/x/build/internal/task: update postTweet to Twitter API v2 when possible2mo
Noting that we ran into the same error today. (CC @cherrymui.) The app once again ended up becoming "standalone" for reasons unknown to us. We re-added it to the project.dmitshur opened an issue golang.org/x/build/cmd/relui: bypass trybots for VERSION file CLs2mo
This is an enhancement to speed up the release process and slightly reduce its resource use, by adding some complexity to its implementation that lets it avoid duplicate work.
The Go build system us…dmitshur closed an issue golang.org/x/build: bot mac-331-h526 reported as broken2mo
By now the bot is back and idle, having run the last 25+ builds successfully. Not sure that there's anything to do here.dmitshur opened an issue golang.org/x/build: gotip-openbsd-riscv64 builder is missing2mo
There are currently no bots running at https://ci.chromium.org/ui/p/golang/builders/ci/gotip-openbsd-riscv64.
CC @4a6f656c, @golang/riscv64.dmitshur opened an issue golang.org/x/build: gotip-freebsd-riscv64 builder is missing2mo
There are currently no bots running at https://ci.chromium.org/ui/p/golang/builders/ci/gotip-freebsd-riscv64.
CC @mengzhuo, @golang/riscv64.dmitshur commented on golang.org/x/build: add LUCI linux-s390x builder2mo
From looking at the source for those functions ([here](https://source.chromium.org/chromium/infra/infra_superproject/+/main:infra/luci/appengine/swarming/swarming_bot/api/platforms/linux.py?q=%22%5B%…