Activity
There was a problem fetching the latest activity.
This Week
dmitshur commented on math/big: broken mips and mips64 builders1d
CC @golang/mips.dmitshur commented on cmd/dist: switch to a devel version format that satisfies go/version.Lang and go/version.IsValid in more cases1d
@xnox Including additional fields about the toolchain and its possible modifications in the build information (in addition to the go version string) like that is an interesting idea. It has some conn…dmitshur commented on internal/fuzz: enable fuzz testing on OpenBSD 1d
It would be good to mention this in Go 1.25 release notes (#71661), otherwise users may not know about it. See [doc/README.md](https://cs.opensource.google/go/go/+/master:doc/README.md).dmitshur commented on golang.org/x/oauth2/google: findDefaultCredentials fallback to ComputeTokenSource should be predicated on availability on service account1d
@seankhliao Can you please clarify what you mean with that comment? Why is this issue closed as not planned?dmitshur commented on golang.org/x/build: add darwin-arm64 longtest and race builders1d
CC @JunyangShao, @prattmic.dmitshur commented on build: build failure on x/crypto GOARCH=loong64 with Go 1.23/1.24 [consistent failure]2d
These build failures are fixed via revert CLs above. Closing.dmitshur fixed an issue build: build failure on x/crypto GOARCH=loong64 with Go 1.23/1.24 [consistent failure]2d
Last Week
dmitshur commented on golang.org/x/build: gotip-linux-amd64-misccompile builder fails with no space left on device1w
We haven't seen this happen for a while, right?
I believe this was a combination of some short-lived builder VMs inadvertently staying around for much longer than intended, and some cache directorie…dmitshur fixed an issue golang.org/x/build: gotip-linux-amd64-misccompile builder fails with no space left on device1w
dmitshur fixed an issue golang.org/x/build: set a maintenance window for the kubernetes instance1w
dmitshur commented on golang.org/x/build: set a maintenance window for the kubernetes instance1w
It seems to be generally working well. Let's call this done; we can reopen if more is needed.dmitshur commented on cmd/compile: infinite loop in the inliner1w
We'll need to create a backport candidate issue for the Go1.24.3 milestone; moving this to Go1.25.dmitshur commented on golang.org/x/build: add LUCI linux-s390x builder1w
@srinivas-pokala I believe the change in [crrev.com/c/6439429](https://crrev.com/c/6439429) is rolled out and you should be able to try starting up the builder again.dmitshur commented on golang.org/x/build/internal/relui: TestRelease/major failures [consistent failure]1w
Fixed by [CL 664495](https://go.dev/cl/664495).dmitshur fixed an issue golang.org/x/build/internal/relui: TestRelease/major failures [consistent failure]1w
dmitshur fixed an issue golang.org/x/build/env: host-linux-amd64-sid (Container Image: linux-x86-sid:latest)1w
dmitshur commented on golang.org/x/build/env: host-linux-amd64-sid (Container Image: linux-x86-sid:latest)1w
Closed by merging [CL 665856](https://go.dev/cl/665856) (commit golang/build@48b27723f5bd8d92de3f0fff371a73debc7d8feb) to `luci-config`.dmitshur fixed an issue golang.org/x/build: consider adding a linux builder with a newer kernel1w
dmitshur commented on golang.org/x/build: consider adding a linux builder with a newer kernel1w
The new issue #73405 (CC @prattmic) is a continuation of this, folding this into that.dmitshur fixed an issue golang.org/x/build/env/linux: add bleeding edge kernel builder1w
dmitshur commented on golang.org/x/build/env/linux: add bleeding edge kernel builder1w
The new issue #73405 (CC @prattmic) is a continuation of this, folding this into that.dmitshur commented on golang.org/x/build: recent Linux kernel builder1w
We can try moving the sid builder (#61112) to cos-dev (up from cos-113-lts). If that ends up being too new and too noisy to be useful, we can move down to something less bleeding edge like cos-beta o…dmitshur fixed an issue build: build failure on gotip-linux-amd64-misccompile [consistent failure]1w
dmitshur commented on math/big: wrong parameter names for mulAddVWW in loong64 assembly [consistent failure]1w
Fixed by [CL 665717](https://go.dev/cl/665717).dmitshur fixed an issue math/big: wrong parameter names for mulAddVWW in loong64 assembly [consistent failure]1w
dmitshur commented on golang.org/x/build/cmd/golangbuild: switch to generating a valid (per go/version.IsValid) version string1w
Yes, agreed, we should apply this to cmd/dist too. Retitled to capture that too.
As for why golangbuild (and coordinator, previously) generates a VERSION file, it does it for a few related reasons:
…dmitshur commented on golang.org/x/review: `~/go/bin/git-codereview change` fails with `git-codereview: not found`1w
It is intended for git-codereview to be available in PATH—see https://go.dev/doc/contribute#git-codereview_install. If you prefer not to add $HOME/go/bin to $PATH, it should still work to place the…dmitshur opened an issue golang.org/x/build/cmd/golangbuild: switch to generating a valid (per go/version.IsValid) version string1w
golangbuild currently generates VERSION files with strings like this, a behavior that the Go build system had for a while:
```
devel <commit>
devel <change>/<patchset>
```
That satisfies the proper…dmitshur commented on go/version: doesn't handle devel toolchain versions1w
The ability to be able to tell that a given Go version isn't a released version can be useful, and quite a bit of code relies on the presence of the "devel" substring as you mentioned. Instead of rem…Earlier
dmitshur commented on golang.org/x/website: automatic URL fragments for sub-sections of 'Minor changes to the library' are overly repetitive1w
I don't think it's viable to rely on manually specifying IDs as in that CL. People will forget to do it in some cases, and changing anchors afterwards on recent release notes might break links.dmitshur fixed an issue golang.org/x/build: migrate low-capacity (reverse) builders to LUCI2w
dmitshur commented on golang.org/x/build: migrate low-capacity (reverse) builders to LUCI2w
This umbrella issue is similar to the #60440 umbrella issue, we can merge them together. Closing this one. Thanks everyone.dmitshur reopened an issue golang.org/x/build/env: host-linux-amd64-sid (Container Image: linux-x86-sid:latest)2w
The build script was updated and a new LUCI-capable image was indeed built, though it's missing python3 (needed for the swarming bot). But we still need to add it to luci-config. Reopening for that.dmitshur fixed an issue golang.org/x/build/cmd/racebuild: Error running create: failed to create buildlet on gotip-linux-loong642w
dmitshur commented on golang.org/x/build/cmd/racebuild: Error running create: failed to create buildlet on gotip-linux-loong642w
Yes, there is some similarity to #67468, but it's not the same issue. Over there it is a problem on the side of Gerrit, where for some reason triggering optional trybots doesn't use your primary Gerr…dmitshur opened an issue golang.org/x/review/git-codereview: TestHooks and 5 more related tests are failing as of "os: avoid symlink races in RemoveAll" on Windows2w
As seen on the [x/review (gotip) by go commit](https://ci.chromium.org/p/golang/g/x-review-gotip-by-go/console) view, a number of tests have begun to fail starting with [CL 661575](https://go.dev/cl/…dmitshur commented on golang.org/x/review/git-codereview: `change -n` still writes the hooks without announcing2w
Thanks for reporting.
This should be a matter of adding a check for `*noRun` inside `installHook`, before it starts to do `os.Mkdir` and `os.WriteFile`.dmitshur commented on golang.org/x/website: clarify Linux installation instructions regarding root/sudo permissions2w
Your suggested alternative sounds good. Please go ahead and send the change.
One minor suggestion, since that is a complete sentence inside the parentheses, let's also move the period to be inside.dmitshur commented on cmd/compile: internal compiler error: assertion failed with type aliases2w
CC @golang/compiler.dmitshur commented on crypto/x509: redundant UnknownExtKeyUsage check in verify.go2w
> So, considering this block of code: if cert has no ExtKeyUsage, but some UnknownExtKeyUsage, we also go through the remaining logic.
It looks like the current code results in such a cert contribut…dmitshur commented on crypto/x509: Go parsed a GeneralName with an incorrect tag2w
CC @golang/security.dmitshur commented on crypto/x509: Go accepts the IDP extension with DER encoding as an empty sequence2w
CC @golang/security.dmitshur commented on golang.org/x/build/cmd/racebuild: Error running create: failed to create buildlet on gotip-linux-loong642w
Does [gomote creation](https://go.dev/wiki/Gomote) work standalone from racebuild, or does it run into the same error? When authenticating, which of the two emails are you using, the @gmail.com one?
…dmitshur commented on github.com/OldUnreal/UnrealTournamentPatches: [469e-RC4] Mac Metal - gamma too high / looks washed out2w
The v469e-rc8 release notes mention something that appears to be relevant to this issue:
> Frucore will now use a 10 bpc frame buffer by default. This should make shadows look noticeably better
I t…dmitshur opened a change github.com/aclements/go-misc/minutes3: close Declined proposals with "not planned" reason2w
GitHub has added dedicated statuses to help distinguish issues that are "completed" from ones that are "not planned". When closing a proposal because it is Declined, the latter status is a better fit…dmitshur fixed an issue golang.org/x/sys/windows: TestBuildSecurityDescriptor failures2w
dmitshur commented on text/template: index/element switched for iter.Seq2 in range2w
CC @robpike, @mvdan.dmitshur commented on golang.org/x/tools/go/cfg: loop variable declarations are misplaced for 1.22+ loops2w
CC @adonovan.dmitshur commented on all: announce end of support for old macOS releases2w
[CL 663515](https://go.dev/cl/663515) added an entry to the Go 1.25 release notes. Moving to the next milestone.dmitshur fixed an issue build: build failure on gotip-linux-arm64-longtest [consistent failure]2w
dmitshur fixed an issue build: build failure on gotip-linux-amd64-longtest-noswissmap [consistent failure]2w
dmitshur fixed an issue build: build failure on gotip-linux-amd64-longtest-aliastypeparams [consistent failure]2w
dmitshur fixed an issue build: build failure on gotip-linux-amd64-longtest [consistent failure]2w
dmitshur fixed an issue build: build failure on gotip-linux-386-longtest [consistent failure]2w
dmitshur closed an issue test: Test fail on riscv64 Alpine Linux starting with Go 1.24.22w
dmitshur commented on golang.org/x/build: add LUCI linux-s390x builder2w
There are two pages linked from https://chromium.googlesource.com/infra/infra/+/main/doc/source.md that might be most relevant, if you haven't already looked there:
- https://commondatastorage.googl…dmitshur fixed an issue runtime: Windows arm64 builder fail to allocate memory2w
dmitshur commented on runtime: Windows arm64 builder fail to allocate memory2w
Indeed. Thanks for filing this issue and de-duplicating all the related watchflakes reports.
The "yesterday afternoon" update was likely an automated one rather than something we did manually.
I've…dmitshur closed an issue golang.org/x/crypto: transitive dependency package "golang.org/x/net" is not updated with latest crypto version2w
The golang.org/x/crypto module only uses the [golang.org/x/net/idna](https://golang.org/x/net/idna) package from the golang.org/x/net module, and that package hasn't changed since v0.21.0: https://go…dmitshur opened an issue golang.org/x/build/cmd/relui: add best-effort updating of tagx:ignore'd dependencies2w
The monthly tagging workflow skips updating modules annotated with `tagx:ignore`. This was done out of necessity to break cycles in the module graph ([CL 439136](https://go.dev/cl/439136)).
This mea…dmitshur commented on runtime: segfaults in runtime.(*unwinder).next2w
CC @golang/runtime.dmitshur commented on context: context.Cause can return nil while Err return non-nil for custom context implmenentations2w
CC @neild, @Sajmani.dmitshur commented on cmd/compile: program compiles to wasm but is invalid: go:wasmexport: integer too large2w
CC @golang/wasm.dmitshur opened an issue go/types: TestFixedbugs/issue70549.go fails on linux-s390x-ibm builder2w
The `TestFixedbugs/issue70549.go` test recently added in [CL 662775](https://go.dev/cl/662775) is consistently failing on linux-s390x-ibm and linux-s390x-ibm-race builders:
```
--- FAIL: TestFixedbu…dmitshur commented on cmd/go: confusing situation with 'go run' and '//go:build ignore'2w
CC @matloob, @samthanawalla (via [owners](https://dev.golang.org/owners)).dmitshur fixed an issue build: build failure on gotip-windows-amd642w
dmitshur commented on os/exec: ocassional fork/exec failures with "The parameter is incorrect." on Windows2w
@qmuntal is [looking into this](https://go-review.googlesource.com/c/go/+/653856/5#message-195160c33eb703a9b3cd6740dec47a275005ac3e). CC @golang/windows.dmitshur fixed an issue runtime:mayMoreStackMove: TestSyscallN/arg-32 failures2w
dmitshur fixed an issue runtime:mayMoreStackMove: TestSyscallN/arg-15 failures2w
dmitshur fixed an issue runtime:mayMoreStackMove: TestSyscallN/arg-13 failures2w
dmitshur fixed an issue cmd/vet: TestVet/stdversion failures2w
dmitshur fixed an issue runtime:mayMoreStackMove: TestSyscallN/arg-33 failures2w
dmitshur fixed an issue runtime:mayMoreStackMove: TestSyscallN/arg-3 failures2w
dmitshur fixed an issue net/textproto: unrecognized failures2w
dmitshur fixed an issue internal/coverage/cfile: TestIssue59563TruncatedCoverPkgAll failures2w
dmitshur fixed an issue runtime:mayMoreStackMove: TestSyscallN/arg-20 failures2w
dmitshur fixed an issue os: TestStartProcess/absolute failures2w
dmitshur commented on golang.org/x/sys/windows: some syscalls are creating dangling pointers2w
CC @golang/windows.dmitshur commented on crypto/tls: ECH decodeInnerClientHello incorrectly rejects ClientHello with GREASE values in supportedVersions [1.24 backport]3w
Can you please clarify if the request to backport to the 1.24 branch is because the problem only exists in 1.24 but not 1.23? Or does this problem affect 1.23 too? We need this information because th…dmitshur commented on golang.org/x/vuln: expose vulnerability feed as rss3w
@zpavlinovic This issue is closed as "completed", is that the right status? Or should it be closed as "not planned"?dmitshur fixed an issue golang.org/x/text: test results fail to be uploaded to ResultDB3w
dmitshur commented on golang.org/x/text: test results fail to be uploaded to ResultDB3w
Fixed via [crrev.com/c/6414930](https://crrev.com/c/6414930), which adds escaping for this character on the side of result_adapter.
Filed #73116 in case there's something the go command can do bette…dmitshur opened an issue cmd/go: consider shrinking set of characters allowed/passed through in subtest names3w
This issue is meant to capture a small finding from #73086, and it's related to the cluster of proposals like #67562 (and its earlier version #45549), #27896, possibly more like #44970, #20209, #2021…dmitshur commented on golang.org/x/mobile: gobind adds local paths to .so file even with -trimpath4w
CC @hajimehoshi.dmitshur opened an issue golang.org/x/text: test results fail to be uploaded to ResultDB4w
The x/text dashboard has turned red:
https://ci.chromium.org/p/golang/g/x-text-gotip-by-go/console
The text execution itself passes, but LUCI builds (for example, https://ci.chromium.org/b/87191676…dmitshur commented on runtime/cgo: naming a DLL exported function as "CloseHandle" causes all DLL exported functions to deadlock4w
CC @golang/runtime, @golang/windows.dmitshur commented on net: ResolveTCPAddr fails with error when resolving a link-local IPv4 address containing a zone4w
CC @ianlancetaylor, @neild.dmitshur commented on debug/buildinfo: fall back code for when there's no .go.buildinfo is wrong1mo
CC @matloob, @samthanawalla.dmitshur commented on crypto/x509: accepts CRL with two AKI extension1mo
CC @golang/security.dmitshur commented on crypto/x509: unexpected handling of escape characters1mo
Thanks. The value of `crl.Issuer.Organization` contains only one backslash character:
```
Organization:[]string{`VeriSign\`}
```
And the String method prints that one backslash in escaped format. H…dmitshur commented on gopls/internal/settings: enable more staticcheck passes1mo
> What is that subset?
As noted at https://staticcheck.dev/docs/configuration/, "Staticcheck tries to provide a good out-of-the-box experience, [...]", that is, this question is already being consid…dmitshur commented on cmd/internal/testdir: testenv.go:166: skipping test: 'go build' not compatible with setting $GO_GCFLAGS1mo
Is this the same as issue #18222?dmitshur commented on cmd/go: cache confuses package with different build tags when using CGO with pkg-config1mo
CC @matloob, @samthanawalla.dmitshur commented on golang.org/x/vuln: expose vulnerability feed as rss1mo
CC @golang/vulndb.dmitshur commented on crypto/x509: accepts invalid AKI extension in CRL1mo
CC @golang/security.dmitshur commented on crypto/x509: incorrect handling of the CRL Number field1mo
CC @golang/security.dmitshur starred github.com/prattmic/benchfmt-convert2mo
dmitshur commented on net/http: TestTransportIdleConnTimeout failures3mo
Looks like [CL 637897](https://go.dev/cl/637897) indeed fixed this. Closing, watchflakes will follow up if it still happens.