Activity
There was a problem fetching the latest activity.
Today
dmitshur commented on crypto/tls: ECH decodeInnerClientHello incorrectly rejects ClientHello with GREASE values in supportedVersions [1.24 backport]11h
Can you please clarify if the request to backport to the 1.24 branch is because the problem only exists in 1.24 but not 1.23? Or does this problem affect 1.23 too? We need this information because th…Yesterday
dmitshur commented on golang.org/x/vuln: expose vulnerability feed as rss1d
@zpavlinovic This issue is closed as "completed", is that the right status? Or should it be closed as "not planned"?This Week
dmitshur fixed an issue golang.org/x/text: test results fail to be uploaded to ResultDB3d
dmitshur commented on golang.org/x/text: test results fail to be uploaded to ResultDB3d
Fixed via [crrev.com/c/6414930](https://crrev.com/c/6414930), which adds escaping for this character on the side of result_adapter.
Filed #73116 in case there's something the go command can do bette…dmitshur opened an issue cmd/go: consider shrinking set of characters allowed/passed through in subtest names3d
This issue is meant to capture a small finding from #73086, and it's related to the cluster of proposals like #67562 (and its earlier version #45549), #27896, possibly more like #44970, #20209, #2021…Last Week
dmitshur commented on golang.org/x/mobile: gobind adds local paths to .so file even with -trimpath6d
CC @hajimehoshi.dmitshur opened an issue golang.org/x/text: test results fail to be uploaded to ResultDB6d
The x/text dashboard has turned red:
https://ci.chromium.org/p/golang/g/x-text-gotip-by-go/console
The text execution itself passes, but LUCI builds (for example, https://ci.chromium.org/b/87191676…dmitshur commented on runtime/cgo: naming a DLL exported function as "CloseHandle" causes all DLL exported functions to deadlock6d
CC @golang/runtime, @golang/windows.dmitshur commented on net: ResolveTCPAddr fails with error when resolving a link-local IPv4 address containing a zone6d
CC @ianlancetaylor, @neild.dmitshur commented on debug/buildinfo: fall back code for when there's no .go.buildinfo is wrong1w
CC @matloob, @samthanawalla.dmitshur commented on crypto/x509: accepts CRL with two AKI extension1w
CC @golang/security.dmitshur commented on crypto/x509: unexpected handling of escape characters1w
Thanks. The value of `crl.Issuer.Organization` contains only one backslash character:
```
Organization:[]string{`VeriSign\`}
```
And the String method prints that one backslash in escaped format. H…dmitshur commented on gopls/internal/settings: enable more staticcheck passes1w
> What is that subset?
As noted at https://staticcheck.dev/docs/configuration/, "Staticcheck tries to provide a good out-of-the-box experience, [...]", that is, this question is already being consid…dmitshur commented on cmd/internal/testdir: testenv.go:166: skipping test: 'go build' not compatible with setting $GO_GCFLAGS1w
Is this the same as issue #18222?dmitshur commented on cmd/go: cache confuses package with different build tags when using CGO with pkg-config1w
CC @matloob, @samthanawalla.dmitshur commented on golang.org/x/vuln: expose vulnerability feed as rss1w
CC @golang/vulndb.dmitshur commented on crypto/x509: accepts invalid AKI extension in CRL1w
CC @golang/security.dmitshur commented on crypto/x509: incorrect handling of the CRL Number field1w
CC @golang/security.dmitshur commented on crypto/x509: unexpected handling of escape characters1w
In the issue report you mention "I use Go to parse this CRL file, Go interprets". Can you please provide a snippet of code for that? In particular, that code will help determine if the problem is in …dmitshur commented on testing: b.StopTimer breaks b.Loop [1.24 backport]1w
@JunyangShao Since you authored the original CL, would you like to create the cherry-pick CL for it too? The process is documented at https://go.dev/wiki/MinorReleases#making-cherry-pick-cls. Thanks.dmitshur commented on crypto/x509: accepts DN with all empty values1w
CC @golang/security.Earlier
dmitshur commented on net/http/httputil: ReverseProxy calls WriteHeader after hijacking connection2w
@neild Both this issue (#72954) and issue #72140 say:
> This is a regression in 1.24 caused by CL 637939 for #35892.
And they both request a backport to 1.24, but as far I can tell, CL 637939 is on…dmitshur commented on testing: structured output for test attributes2w
To clarify, is it intentional that the test2json line would exclude remaining TestEvent fields like "Time", "Package" (in contrast to https://github.com/golang/go/issues/71287#issuecomment-2737759645…dmitshur closed an issue golang.org/x/build/env: host-freebsd-amd64-12_3 (VM Image: freebsd-amd64-123-stable-20211230)2w
FreeBSD 12.3 is EOL'ed as noted in https://github.com/golang/go/issues/61095#issuecomment-2334940821. We ended up adding a newer FreeBSD 14.1 as part of that issue, so there's nothing more to do for …dmitshur commented on golang.org/x/build/env: host-openbsd-386-* (VM Image: openbsd-386-*)2w
It was possible to successfully build the image, and its swarming bot client successfully connects with `cipd_platform:openbsd-386`:
https://chromium-swarm.appspot.com/botlist?f=cipd_platform%3Aopen…dmitshur commented on golang.org/x/tools/gopls/internal/test/integration: 10 tests failing on openbsd/amd64 after OpenBSD 7.2 → 7.6 upgrade2w
The flakes in #54461 seem to happen on OpenBSD 7.2 builders only. [CL 654676](https://go.dev/cl/654676) replaces the previous OpenBSD 7.2 builders with the new 7.6 ones, so those those will go away.
…dmitshur fixed an issue golang.org/x/build: bot netbsd-arm64-bsiegert reported as broken2w
dmitshur commented on golang.org/x/build: bot netbsd-arm64-bsiegert reported as broken2w
The builder is currently operational. Thanks for resolving this @bsiegert. Closing.dmitshur fixed an issue golang.org/x/build: bot solaris-amd64 reported as broken2w
dmitshur commented on golang.org/x/build: bot solaris-amd64 reported as broken2w
The builder is currently operational. Thanks for resolving this. Closing.dmitshur commented on golang.org/x/build: bot openbsd-ppc64-n2vi reported as broken2w
The builder is currently operational. Thanks for resolving this @n2vi. Closing.dmitshur fixed an issue golang.org/x/build: bot openbsd-ppc64-n2vi reported as broken2w
dmitshur fixed an issue golang.org/x/build: bot aix-ppc64-power8 reported as broken2w
dmitshur commented on golang.org/x/build: bot aix-ppc64-power8 reported as broken2w
This bot doesn't exist now. It existed briefly (see https://github.com/golang/go/issues/67299#issuecomment-2276610972) but has since been deleted because its cipd_platform was incorrectly computed.
…dmitshur fixed an issue golang.org/x/build: bot linux-ppc64le-power8--03 reported as broken2w
dmitshur commented on golang.org/x/build: bot linux-ppc64le-power8--03 reported as broken2w
Fixed alongside #72851.dmitshur commented on golang.org/x/build: bot linux-ppc64le-power8--05 reported as broken2w
CC @golang/release.
Fixed alongside #72851.dmitshur fixed an issue golang.org/x/build: bot linux-ppc64le-power8--05 reported as broken2w
dmitshur fixed an issue golang.org/x/build: bot linux-ppc64le-power8--04 reported as broken2w
dmitshur commented on golang.org/x/build: bot linux-ppc64le-power8--04 reported as broken2w
Fixed alongside #72851.dmitshur fixed an issue golang.org/x/build: bot linux-ppc64le-power8--02 reported as broken2w
dmitshur commented on golang.org/x/build: bot linux-ppc64le-power8--02 reported as broken2w
Fixed alongside #72851.dmitshur fixed an issue golang.org/x/build: bot linux-ppc64le-power8--01 reported as broken2w
dmitshur commented on golang.org/x/build: bot linux-ppc64le-power8--01 reported as broken2w
Thanks!dmitshur merged a change rsc.io/rf/git-generate: modernize slightly2w
dmitshur commented on rsc.io/rf/git-generate: modernize slightly2w
Thanks.dmitshur commented on golang.org/x/build/cmd/gomote: linux-loong64 gomote creation fails with "HTTP Error 403: Forbidden"2w
Whoops, that file wasn't present in the GCS bucket. (Thanks @cagedmantis for spotting the issue!) I've sent [CL 657995](https://go.dev/cl/657995) that adds it as a target and uploaded it now.
Gomote…dmitshur opened an issue golang.org/x/build/cmd/gomote: linux-loong64 gomote creation fails with "HTTP Error 403: Forbidden"2w
Create a gotip-linux-loong64 gomote results in an error. Filing this as a tracking issue.
A swarming task is successfully created, but the task fails. https://chromium-swarm.appspot.com/task?id=6fad…dmitshur commented on golang.org/x/build: bot linux-ppc64le-power8--01 reported as broken3w
CC @golang/ppc64.dmitshur commented on golang.org/x/build: add LUCI openbsd-riscv64 builder3w
@4a6f656c The CL above implements the change you requested, please feel free to review it when you get a chance. Leaving this to you, but please ping this issue if there's something we can do to help…dmitshur commented on golang.org/x/build: automate consequences of go.mod go directive maintenance3w
We can add tasks that run after the go directive maintenance happens as part of the major Go release relui workflow, here: https://cs.opensource.google/go/x/build/+/master:internal/relui/workflows.go…dmitshur commented on github.com/KhronosGroup/WebGL: Add drawingBufferStorage test from @ccameron-chromium .3w
This `contextVersion` parameter is unused, which prevents runTest(1) and runTest(2) from testing both WebGL 1 and 2 contexts. I filed #3719 for this and another issue related to RGBA16F that I spot…dmitshur opened an issue github.com/KhronosGroup/WebGL: drawingBufferStorage Conformance Tests test webgl1 instead of webgl2, skip RGBA16F in webgl1 without EXT_color_buffer_float extension3w
Consider the following two pages:
- WebGL drawingBufferStorage Conformance Tests - https://registry.khronos.org/webgl/sdk/tests/conformance/canvas/drawingbuffer-storage-test.html
- WebGL2 drawingBuf…dmitshur commented on golang.org/x/tools/refactor/eg: Using `./...` only matches one file even though there are many more3w
This issue might be the same as #10142.dmitshur closed an issue iter: add `Push` function3w
dmitshur commented on golang.org/x/build/cmd/watchflakes: opened over 500 duplicate issues on 2025-03-073w
I didn't spot problems in the client code, and based on what @aarzilli observed, it seems we can't discount the possibility of GitHub returning an incomplete issue list without also reporting an erro…dmitshur commented on golang.org/x/build/cmd/watchflakes: opened over 500 duplicate issues on 2025-03-073w
Timing seems to align with https://www.githubstatus.com/incidents/lb0d8kp99f2v:
> Issues is experiencing degraded performance.
> Searches for issues and pull-requests may be slower than normal and…dmitshur commented on golang.org/x/build/cmd/watchflakes: opened over 500 duplicate issues on 2025-03-073w
The problem doesn't reproduce when running watchflakes locally now:
```
[…]
watchflakes: 2025/03/07 11:24:53 readComments 60085
watchflakes: 2025/03/07 11:24:53 readComments 70602
watchflakes: 202…dmitshur commented on golang.org/x/build: update OpenBSD builders to 7.64w
From looking at https://ci.chromium.org/ui/p/golang/builders?q=openbsd-amd64_7.6, the openbsd/amd64 builder with OpenBSD 7.6 is still running into what looks like #66474, possibly less frequently aft…dmitshur opened an issue golang.org/x/tools/gopls/internal/test/integration: 10 tests failing on openbsd/amd64 after OpenBSD 7.2 → 7.6 upgrade4w
As visible at https://ci.chromium.org/ui/p/golang/builders/ci/x_tools-gotip-openbsd-amd64_7.6 (comparing it with https://ci.chromium.org/ui/p/golang/builders/ci/x_tools-gotip-openbsd-amd64), there ar…dmitshur commented on cmd/go: provide a convenient way to iterate all packages in go.work workspace4w
Given the change in #71294 is now implemented, we can't release Go 1.25 without having it also be documented and mentioned in release notes. Since that issue is already closed but this one's still op…dmitshur commented on golang.org/x/build/cmd/relui: add support for making release announcement posts on Bluesky4w
@fflewddur To clarify, that time when you saw it already posted, it must've been posted manually by someone else. The work of automating this hasn't been done yet, but this issue tracks progress on d…dmitshur commented on cmd/go: removed godebug settings cause errors4w
I’m not familiar the specifics of why the `tlskyber` godebug was added in Go 1.23 and removed in 1.24, but I’ll note that https://go.dev/doc/godebug includes:
> GODEBUG settings added for compat…dmitshur commented on cmd/go: test failures due to dependency downloads running into "close <path>: file already closed" errors4w
Also seeing at least one instance of this in #65482, and I most recently ran into it in the first trybot run of [CL 655037](https://logs.chromium.org/logs/golang/buildbucket/cr-buildbucket/8721234441…dmitshur fixed an issue cmd/go: TestScript/mod_tidy_diff failures4w
dmitshur commented on golang.org/x/build: update OpenBSD builders to 7.61mo
Trying it again without any changes resulted in no errors this time:
<details>
```
[…]
+ pkg_add -iv -I bash curl git python%3 sudo--gettext
[…]
git-2.46.1 (installing)
Shell /usr/local/bin/git…dmitshur closed an issue image: add `(*Uniform).SubImage`1mo
dmitshur commented on golang.org/x/build: update OpenBSD builders to 7.61mo
@4a6f656c Thanks for the hint, it was right on. The output from my run of `VERSION=7.6 ARCH=amd64 ./make.bash` indeed included a line "pkg_add: Installation of python-3.11.10p1 failed, partial instal…dmitshur commented on net/textproto: canonicalMIMEHeaderKey returns a "malformed MIME header line:" for header containing /1mo
Closed by merging [CL 601555](https://go.dev/cl/601555) (commit 3b9d10cce787a6ab358a489b604edccb5414baf2).dmitshur fixed an issue net/textproto: canonicalMIMEHeaderKey returns a "malformed MIME header line:" for header containing /1mo
dmitshur commented on cmd/compile: out of memory [1.23 backport]1mo
> is it because I've said 1.23.6 in the body ?
Yes; we should fix #27489.dmitshur fixed an issue : add date to release notes1mo
dmitshur fixed an issue : Release Notes should be dated1mo
dmitshur commented on cmd/go: option to bundle wasm output with wasm_exec.js1mo
Noting here that there's some similarity here with a previous request to add cmd/go support for multi-architecture macOS binaries (issue #40698). In both cases, it's something that can also be done b…dmitshur merged a change github.com/go-gl/glfw/v3.3/glfw: format glfw_tree_rebuild.go1mo
dmitshur commented on github.com/go-gl/glfw/v3.3/glfw: format glfw_tree_rebuild.go1mo
No worries. Thanks.dmitshur opened a change rsc.io/rf/git-generate: modernize slightly1mo
The go1.16 build constraint was added back when git-generate was tested with Go 1.15 and 1.16, and its intention was to raise the minimum to as high as 1.16.
By now, the go directive in go.mod is …dmitshur opened a change github.com/go-gl/glfw/v3.3/glfw: format glfw_tree_rebuild.go1mo
CI is correctly finding a formatting issue: https://github.com/go-gl/glfw/actions/runs/13575085829/job/37949278897. This should fix it. Generated with [git-generate](https://rsc.io/rf/git-generate):
…dmitshur fixed an issue golang.org/x/build: add automated notifications for missing builders to its owner and/or golang-dev1mo
dmitshur commented on golang.org/x/build: add automated notifications for missing builders to its owner and/or golang-dev1mo
Watchflakes has started to automatically report missing builders (CC @cagedmantis).
Closing this in favor of the newer issue #68790.dmitshur fixed an issue golang.org/x/build: `unexpected EOF` from `symbolic-datum-552` module proxy1mo
dmitshur commented on golang.org/x/build: `unexpected EOF` from `symbolic-datum-552` module proxy1mo
This issue is specific to old infra where we ran an internal module proxy to work around no-network disabling internet access. LUCI builders download dependencies before activating the no-network che…dmitshur commented on golang.org/x/build: build and test failures on openbsd-amd64 builders1mo
@ianlancetaylor Thanks for the suggested change at https://github.com/golang/go/issues/66474#issuecomment-2672475706.
Joel sent [CL 618895](https://go.dev/cl/618895) which doubles :maxproc-max from …dmitshur fixed an issue build: build failure on gotip-linux-amd64_c3h88-perf_vs_release1mo
dmitshur fixed an issue build: build failure on go1.22-linux-amd64_c3h88-perf_vs_release1mo
dmitshur fixed an issue build: build failure on go1.23-linux-amd64_c3h88-perf_vs_release1mo
dmitshur commented on golang.org/x/build: update OpenBSD builders to 7.61mo
The image and configuration for openbsd/amd64 with OpenBSD 7.6 are in place, but the swarming bot is currently failing to start up. I commented [here](https://go-review.googlesource.com/c/build/+/618…dmitshur opened an issue golang.org/x/build/env/freebsd-amd64: doesn't handle reboot and/or termination requests1mo
A swarming bot may trigger a reboot or shutdown of a bot running in GCE, a process that involves /sbin/shutdown. This seems not to work for [freebsd/amd64 builders in GCE](https://chromium-swarm.apps…dmitshur fixed an issue golang.org/x/build: auto-detect flakes1mo
dmitshur commented on golang.org/x/build: auto-detect flakes1mo
I think we can call this done. https://go.dev/wiki/Watchflakesdmitshur fixed an issue golang.org/x/website/tour: installing @latest gets older version1mo
dmitshur commented on golang.org/x/website/tour: installing @latest gets older version1mo
We've retracted all versions of the unintended x/website/tour module in [v0.1.0](https://pkg.go.dev/golang.org/x/website/tour@v0.1.0?tab=versions) (including v0.1.0 itself), so now installing or runn…dmitshur commented on golang.org/x/build: bot plan9-386 reported as broken1mo
It appears this issue is resolved by now. The plan9-386 bot is currently alive and [working](https://ci.chromium.org/ui/p/golang/builders/luci.golang.ci/gotip-plan9-386). Thanks.dmitshur fixed an issue golang.org/x/build: bot plan9-386 reported as broken1mo
dmitshur fixed an issue golang.org/x/tools/cmd/present: remove/hide/disable Native Client for Go 1.14 or newer1mo
dmitshur commented on golang.org/x/tools/cmd/present: remove/hide/disable Native Client for Go 1.14 or newer1mo
Fixed by [CL 468355](https://go.dev/cl/468355) (commit golang/tools@c3550e9181961ca59dfc54232f9690ee4794dbe1).dmitshur fixed an issue golang.org/x/tools/cmd/present: doesn't work with go in git master (1.16)1mo
dmitshur starred github.com/prattmic/benchfmt-convert1mo