dmitri.shuralyov.com/app/changes

Handle binary/garbage file diffs gracefully. dmitri.shuralyov.com/app/changes#2

Opendmitshur opened this issue 6 years ago

dmitshur commented 6 years ago · edited

Right now it's not always the case.

E.g., https://dmitri.shuralyov.com/changes/github.com/shurcooL/home/18/files/7560f8ba15c0b4e816f688fa196a1b1e9ff70fa2 errors on diff for scratch/objects/49/7b436c54d3ed8ccd8f784796cba7f44a44bab6 file.

Also consider making diff renders non-fatal; rather display "error diffing" and keep trying the next file.

dmitshur commented 6 years ago

Actually, the problem was not in diffing but rather in highlighting the diff. It's possible to fall back to displaying plain diff. This was done in commit dd031534, which helps this issue.

to comment.